When an instance of TFS2008 (or 2005) is to be upgraded to TFS2010 the SQL Server must be upgraded to 2008 (sp1) as a minimum. I expected this to be the smallest issue but the problem that:
"Rule 'Consistency validation for SQL Server registry keys' failed". The SQL Server registry keys from a prior installation cannot be modified. To continue, see SQL Server Setup documentation about how to fix registry keys.
It turned out to be a problem with the permissions for a registry key for SQL Server. Even though I tried to upgrade with an account with local admin rights there was a registry key which didn't allow access. For this particular instance it was the key:
HKEY_LOCAL_MACHINE\Software\Microsoft\Microsoft SQL Server\UDDI\MSSQLServer\SuperSocketNetLib\Lpc
The solution was to add the account which was used for the upgrade to have full access to this key. Probably write acces would have been sufficient.
The way to find out which key(s) it is/are is to look in the SQL Server installation log:
Folder: .\Microsoft SQL Server\100\Setup Bootstrap\LOG\ ("and then the date and time of the upgrade attempt")
Look for "System.UnauthorizedAccessException" in the Details.txt file
///Jørn